Skip to content

[bot] Merge master/1daa2c40 into rel/dev - #1843

Merged
yenkins-admin merged 1 commit into
rel/devfrom
snapshot-master-1daa2c40-to-rel/dev
Oct 5, 2026
Merged

yenkins-admin merged 1 commit into
rel/devfrom
snapshot-master-1daa2c40-to-rel/dev

Conversation

@yenkins-admin

Copy link
Copy Markdown
Contributor

🚀 Automated PR to perform merge from master into rel/dev with changes up to 1daa2c4 (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/37293728634).

* feat(gooddata-eval): add the agentic anomaly-detection evaluator

Scores the anomaly-detection skill end to end, with the granularity map aligned to what
the service actually accepts and whole-conversation latency and cost rather than the
goal turn's alone.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* fix(gooddata-eval): let --gate decide an anomaly item, not pass@K alone

`run_agentic_anomaly_detection` already computed `pass_power_k`; the evaluator
never read it, asking `if not summary.pass_at_k` for the verdict, so `--gate
power` on a flaky item reported a pass on the strength of one good run out of K.

Wired the same way as the other multi-run kinds: the evaluator takes `gate`, the
dispatch passes it, `gate_passed(...)` decides, the gate's note goes into the
assertion message -- which matters because the body describes the BEST run, and
under pass^K that can be one that passed -- and pass@K/pass^K/gate_passed reach
Langfuse alongside the run metadata stamp.

The default is unchanged: without --gate this is pass@K exactly as before, pinned
by a test beside the power case. The power test fails against the previous code.

Found by CodeRabbit on #1798. Forecasting is fixed there; what-if, which is
already on master, in #1831.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
@yenkins-admin
yenkins-admin merged commit e631fc2 into rel/dev Oct 5, 2026
3 checks passed
@yenkins-admin
yenkins-admin deleted the snapshot-master-1daa2c40-to-rel/dev branch October 5, 2026 10:00
@coderabbitai

coderabbitai Bot commented Oct 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 94a1abb2-a297-4398-8305-5de8e349d04b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.94656% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.84%. Comparing base (c3c5284) to head (1daa2c4).
⚠️ Report is 600 commits behind head on rel/dev.

Files with missing lines Patch % Lines
...rc/gooddata_eval/core/agentic/anomaly_detection.py 96.91% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           rel/dev    #1843      +/-   ##
===========================================
+ Coverage    83.69%   83.84%   +0.15%     
===========================================
  Files          331      332       +1     
  Lines        22447    22709     +262     
===========================================
+ Hits         18787    19041     +254     
- Misses        3660     3668       +8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants