Commit a5950ca
🔧 Remove optional dependency on the unmaintained
## Summary
Supersedes #401 by @nikolas, whose fork does not allow maintainer
pushes; their commit is carried here verbatim with authorship preserved
(thank you!).
The `commonmark` PyPI package was deprecated in 2022 (last release
2019). #401 dropped it from the `compare` extra but left
`benchmarking/bench_packages.py::test_commonmark_py` importing it
unguarded, so `tox -e py311-bench-packages` (which installs
`benchmarking,compare`) would have errored. This PR removes that
benchmark too.
The `commonmark-py` row in `docs/performance.md` is **kept**, with a
footnote explaining that the package is deprecated, has been removed
from the benchmark suite, and that the figures are from the last run
that included it. The historical comparison is still informative.
A changelog line with the rationale is added.
## Commits
1. `Remove optional dependency on commonmark` — the contributor's
commit, unchanged.
2. `🔧 MAINTAIN: Remove remaining commonmark references` — drops the
orphaned benchmark, adds the changelog line.
3. `📚 DOCS: Keep the commonmark-py benchmark row, with a deprecation
footnote`, plus a changelog wording tweak.
## Verification
- All tests pass; all pre-commit hooks pass under the new pins.
- Local docs build renders the footnote and adds no warnings over
master.
- Remaining `commonmark` mentions in `pyproject.toml`, `tox.ini` and
`benchmarking/` refer to the CommonMark spec or the `commonmark` preset,
none to the package.
---------
Co-authored-by: Nikolas Nyby <nikolas@gnu.org>commonmark package (#427)1 parent 2700cc3 commit a5950ca
4 files changed
Lines changed: 3 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | 38 | | |
47 | 39 | | |
48 | 40 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
39 | 38 | | |
40 | 39 | | |
41 | 40 | | |
| |||
0 commit comments