Skip to content

postgres: fix queries for prop create index, and for primary keys - #377

Closed
kapouer wants to merge 1 commit into
dresende:masterfrom
kapouer:pg-index
Closed

kapouer wants to merge 1 commit into
dresende:masterfrom
kapouer:pg-index

Conversation

@kapouer

@kapouer kapouer commented Nov 7, 2013

Copy link
Copy Markdown
Contributor

they were totally broken ;)

@dresende

dresende commented Nov 8, 2013

Copy link
Copy Markdown
Owner

I'm going to move DML part to an external module. I've done it, just need a few more checks. Change can then be done there.

@dresende dresende closed this Nov 8, 2013
@kapouer

kapouer commented Nov 8, 2013

Copy link
Copy Markdown
Contributor Author

Really ? i found node-orm2 more appealing precisely because it bundles the drivers,
so all drivers are supposed to be on-par quality-wise.

@dresende

dresende commented Nov 8, 2013

Copy link
Copy Markdown
Owner

Sorry, I meant DDL (database synching). I'm doing the move now to https://github.com/dresende/node-sql-ddl-sync

@dresende

dresende commented Nov 8, 2013

Copy link
Copy Markdown
Owner

The module is mine, so they will be kept on par. The difference is that in the module I and any contributors can focus on table synching (avoiding dropping table and recreating when a new property is needed).

@kapouer

kapouer commented Nov 8, 2013

Copy link
Copy Markdown
Contributor Author

i understand, in fact i was afraid you were talking about splitting each database driver in its own module.

@dresende

dresende commented Nov 9, 2013

Copy link
Copy Markdown
Owner

I just made the PR #383, will merge it now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants