Repository navigation
Add loong64 to manifest annotation and bash completion - #7447
wojiushixiaobai wants to merge 1 commit into
Conversation
Signed-off-by: 吴小白 <296015668@qq.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
I may have a quick look at implementing the validation with containerd/platforms instead.
| arm64 | ||
| mips64 | ||
| mips64le | ||
| loong64 | ||
| ppc64le |
There was a problem hiding this comment.
Looks like this list was sorted, so loong64 should come before mips64
| {os: "linux", arch: "amd64"}: true, | ||
| {os: "linux", arch: "arm"}: true, | ||
| {os: "linux", arch: "arm64"}: true, | ||
| {os: "linux", arch: "loong64"}: true, |
There was a problem hiding this comment.
From my other comment on the ticket #7446 (comment)
This validation in general is probably doing too much; it probably shouldn't be aware of "known" platforms (or os/arch combinations); while the OCI has a list of known variants that should be supported, it does allow other values, so at most it should look for missing (empty) fields that are required, and malformed values, but otherwise be un-opinionated.
Adds
linux/loong64to the manifest annotation platform allowlist andloong64to Bash completion.Fixes: #7446