rebasing 18d5e8ce6 strerror is now thread safe

Author: andrew-aitchison

addons/threadsafety.py

@@ -91,7 +91,6 @@
     'race:stdin',
     'race:stdout',
     'race:streams',
-    'race:strerror',
     'race:strsignal',
     'race:strtok',
     'race:tmbuf',
@@ -261,7 +260,6 @@
     'siginterrupt',
     'sleep',
     'srand48',
-    'strerror',
     'strsignal',
     'strtok',
     'tmpnam',

test/cli/other_test.py

@@ -482,9 +482,9 @@ def test_addon_threadsafety(tmpdir):
     test_file = os.path.join(tmpdir, 'test.cpp')
     with open(test_file, 'wt') as f:
         f.write("""
-extern const char* f()
+extern void f()
 {
-    return strerror(1);
+    elf_fill(1);
 }
         """)
 
@@ -496,7 +496,7 @@ def test_addon_threadsafety(tmpdir):
     assert lines == [
         'Checking {} ...'.format(test_file)
     ]
-    assert stderr == '{}:4:12: warning: strerror is MT-unsafe [threadsafety-unsafe-call]\n'.format(test_file)
+    assert stderr == '{}:4:5: warning: elf_fill is MT-unsafe [threadsafety-unsafe-call]\n'.format(test_file)
 
 
 def test_addon_naming(tmpdir):
@@ -4927,6 +4927,7 @@ def test_ipc_inline_suppressions(tmp_path):
     assert stdout_lines == stdout_exp
     assert stderr.splitlines() == []
 
+
 test_redundant_file_reads_params = [
     ([],                       3),
     (['--suppress=zerodiv'],   1),