Fix #15156: Enhancement: Add support for move-assignment for operatorEqToSelf (#8977)

Author: olabetskyi

lib/checkclass.cpp

@@ -1924,7 +1924,7 @@ void CheckClassImpl::operatorEqToSelf()
                 if (func.argumentList.empty())
                     continue;
                 const Token* typeTok = func.argumentList.front().typeEndToken();
-                while (typeTok->str() == "const" || typeTok->str() == "&" || typeTok->str() == "*")
+                while (typeTok->str() == "const" || typeTok->str() == "&" || typeTok->str() == "&&" || typeTok->str() == "*")
                     typeTok = typeTok->previous();
                 if (typeTok->str() != scope->className)
                     continue;

test/testclass.cpp

@@ -84,6 +84,7 @@ class TestClass : public TestFixture {
         TEST_CASE(operatorEqToSelf7);
         TEST_CASE(operatorEqToSelf8);   // ticket #2179
         TEST_CASE(operatorEqToSelf9);   // ticket #2592
+        TEST_CASE(operatorEqToSelf10);  // ticket #15156
 
         TEST_CASE(memsetOnStruct);
         TEST_CASE(memsetVector);
@@ -2674,6 +2675,23 @@ class TestClass : public TestFixture {
         ASSERT_EQUALS("", errout_str());
     }
 
+    void operatorEqToSelf10() {
+        checkOpertorEqToSelf(
+            "class Foo\n"
+            "{\n"
+            "    int32_t * p;\n"
+            "public:\n"
+            "    Foo& operator=( Foo && o ) noexcept\n"
+            "    {\n"
+            "        delete p;\n"
+            "        p = o.p;\n"
+            "        o.p = nullptr;\n"
+            "        return *this;\n"
+            "    }\n"
+            "};\n");
+        ASSERT_EQUALS("[test.cpp:5:10]: (warning) 'operator=' should check for assignment to self to avoid problems with dynamic memory. [operatorEqToSelf]\n", errout_str());
+    }
+
     struct CheckVirtualDestructorOptions
     {
         bool inconclusive = false;