From 64c86357cc9bef0576b4bbf39e986e405de10de9 Mon Sep 17 00:00:00 2001 From: Nicolas Joubert Date: Wed, 14 Oct 2026 16:12:56 +0200 Subject: [PATCH] chore(ci) #49 Test the lowest dependencies, require psr/log ^2|^3 Add a "PHP 8.2 + lowest" job to the test workflow: it installs the lowest versions allowed by composer.json (--prefer-lowest --prefer-stable) on the lowest supported PHP version. This set revealed a wrong lower bound: with psr/log 1.1.0, cleverage/process-bundle 5.0 (and the test logger) declare the typed LoggerInterface::log() signature, which is a fatal error ("Declaration of CleverAge\ProcessBundle\Logger\AbstractLogger::log(...) must be compatible with Psr\Log\LoggerInterface::log($level, $message, array $context = [])"). Require psr/log ^2|^3, as cleverage/process-bundle now does. Co-Authored-By: Claude Opus 5.5 (1M context) --- .github/workflows/test.yml | 6 ++++++ CHANGELOG.md | 1 + composer.json | 2 +- 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index b49e0ce..90a11b6 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -29,6 +29,12 @@ jobs: symfony-require: [''] variant: [normal] include: + # Lowest versions allowed by composer.json, on the lowest supported PHP version + - php-version: '8.2' + dependencies: lowest + allowed-to-fail: false + symfony-require: '' + variant: normal - php-version: '8.2' dependencies: highest allowed-to-fail: false diff --git a/CHANGELOG.md b/CHANGELOG.md index fb71ade..ba4733e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,7 @@ Latest ------ ### Changes +* [#49](https://github.com/cleverage/flysystem-process-bundle/issues/49) CI: test the lowest versions allowed by `composer.json` (`--prefer-lowest`, PHP 8.2). Require `psr/log` `^2|^3`: `cleverage/process-bundle` 5.x uses the typed `LoggerInterface` signatures (fatal error with `psr/log` 1). * [#47](https://github.com/cleverage/flysystem-process-bundle/issues/47) Add a `.gitattributes`: the development files (`.docker/`, `.github/`, `tests/`, quality tools and PHPUnit configurations, `Makefile`) are no longer part of the archive installed by Composer (`dist`). * [#45](https://github.com/cleverage/flysystem-process-bundle/issues/45) Require `league/flysystem` and `psr/log`, used directly by the tasks but only installed through `league/flysystem-bundle` and `cleverage/process-bundle`; add `league/flysystem-local` (used by the tests) to the dev requirements. diff --git a/composer.json b/composer.json index 403a04f..e74bd9e 100644 --- a/composer.json +++ b/composer.json @@ -53,7 +53,7 @@ "cleverage/process-bundle": "^5.0", "league/flysystem": "^3.0", "league/flysystem-bundle": "^3.0", - "psr/log": "^1|^2|^3", + "psr/log": "^2|^3", "symfony/config": "^6.4|^7.4|^8", "symfony/dependency-injection": "^6.4|^7.4|^8", "symfony/finder": "^6.4|^7.4|^8",