Skip to content

test(mosaic): cover enterprise logos, password strength checks and the passkey name limit - #10474

Merged
alexcarpenter merged 1 commit into
mainfrom
carp/mosaic-user-profile-step2-tests
Oct 28, 2026
Merged

alexcarpenter merged 1 commit into
mainfrom
carp/mosaic-user-profile-step2-tests

Conversation

@alexcarpenter

Copy link
Copy Markdown
Member

Description

Tightens user profile tests that let a broken line in the model pass. Each change fails when the matching model line is broken by hand (a hand-run mutation pass).

  • Enterprise accounts: the projection test now checks the logo for both linked accounts and available connections. Dropping either logo used to pass.
  • Password: when the strength checker can't load, the length rule still shows until the password is long enough, then the load failure shows. A new test checks that no strength verdict is given when the instance turns the checker off.
  • Passkeys: the name limit is now tested right at 257 bytes instead of 260.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other: tests

@vercel

vercel Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Oct 27, 2026 9:16pm UTC
swingset Ready Ready Preview Oct 27, 2026 9:16pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 870b9a7 and 39287ae.

Files selected for processing: 4
  • .changeset/mosaic-user-profile-step2-tests.md
  • packages/mosaic/src/features/user-profile/user-profile-enterprise-accounts-section/__tests__/user-profile-enterprise-accounts-projection.test.ts
  • packages/mosaic/src/features/user-profile/user-profile-passkeys-section/__tests__/user-profile-passkeys-validation.feature.test.tsx
  • packages/mosaic/src/features/user-profile/user-profile-password-section/__tests__/user-profile-password-section.feature.test.tsx
Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 1 remain after this review.

Walkthrough

The PR updates user-profile tests for enterprise-account icon URLs, UTF-8 passkey name length boundaries, and password validation when the strength checker fails or is disabled. It also adds empty front matter to a changeset file, with no release note or package version declaration.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: austincalvelage, ephem

Merge Risk: Minimal · up to 39287

No actionable merge-blocking risk was identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Description check Passed The description directly explains the added tests for enterprise logos, password-strength behavior, and the passkey name limit.
Title check Passed The title clearly summarizes the main test coverage: enterprise logos, password-strength checks, and the passkey name limit.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 3 files. (1 skipped: 1 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Linked repositories: Some configured repositories could not be included in this review. Cross-repository analysis may be incomplete. Please check linked-repository access and settings.

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Oct 27, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@10474

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@10474

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@10474

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@10474

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@10474

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@10474

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@10474

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@10474

@clerk/expo-biometrics

npm i https://pkg.pr.new/@clerk/expo-biometrics@10474

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@10474

@clerk/expo-native-components

npm i https://pkg.pr.new/@clerk/expo-native-components@10474

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@10474

@clerk/express

npm i https://pkg.pr.new/@clerk/express@10474

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@10474

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@10474

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@10474

@clerk/mosaic

npm i https://pkg.pr.new/@clerk/mosaic@10474

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@10474

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@10474

@clerk/react

npm i https://pkg.pr.new/@clerk/react@10474

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@10474

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@10474

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@10474

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@10474

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@10474

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@10474

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@10474

commit: 39287ae

@alexcarpenter
alexcarpenter merged commit b658f44 into main Oct 28, 2026
56 checks passed
@alexcarpenter
alexcarpenter deleted the carp/mosaic-user-profile-step2-tests branch October 28, 2026 17:23

This branch was successfully deployed

2 active deployments
Preview – swingset — 39287ae7 Deployed Oct 27, 2026 by vercel[bot]
Preview – clerk-js-sandbox — 39287ae7 Deployed Oct 27, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants