Skip to content

Commit 246cae9

Browse files
authored
Merge pull request #69 from cdepillabout/more-fixes
Add some updates for various packages
2 parents 108f6ab + 55db814 commit 246cae9

2 files changed

Lines changed: 27 additions & 3 deletions

File tree

nix/build-support/stacklock2nix/cabal2nixArgsForPkg.nix

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,17 @@ cabal2nixArgsOverrides {
125125
else
126126
{};
127127

128-
"test-framework" = ver: { libxml = pkgs.libxml; };
128+
"test-framework" = ver:
129+
# All versions of test-framework before 0.8.2.2 required the libxml package,
130+
# but 0.8.2.2 and later don't require this.
131+
if pkgs.lib.versionAtLeast ver "0.8.2.2" then
132+
{}
133+
else
134+
# TODO: Eh, this isn't quite correct. test-framework requires the libxml
135+
# haskell package, which should be pulling in and propagating the libxml
136+
# system package. I don't know how this was ever working, but it does
137+
# seem to work.
138+
{ libxml = pkgs.libxml; };
129139

130140
"termonad" = ver: { vte_291 = pkgs.vte; gtk3 = pkgs.gtk3; pcre2 = pkgs.pcre2;};
131141

nix/build-support/stacklock2nix/suggestedOverlay.nix

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,9 @@ hfinal: hprev: with haskell.lib.compose; {
6565
# doctests fail
6666
bsb-http-chunked = dontCheck hprev.bsb-http-chunked;
6767

68+
# tests don't work when run with nix
69+
call-stack = dontCheck hprev.call-stack;
70+
6871
# Tests don't include all necessary files.
6972
c2hs = dontCheck hprev.c2hs;
7073

@@ -75,6 +78,7 @@ hfinal: hprev: with haskell.lib.compose; {
7578

7679
colour = dontCheck hprev.colour;
7780

81+
# circular dep in tests
7882
doctest = dontCheck hprev.doctest;
7983

8084
doctest-parallel = dontCheck hprev.doctest-parallel;
@@ -200,16 +204,22 @@ hfinal: hprev: with haskell.lib.compose; {
200204
# circular dependency in tests
201205
options = dontCheck hprev.options;
202206

207+
# circular dependency in tests
208+
optparse-applicative = dontCheck hprev.optparse-applicative;
209+
203210
# tests require postgres running
204211
pg-transact = dontCheck hprev.pg-transact;
205212

206213
# Tests run for a really long time, and also require a broken package.
207214
prettyprinter = dontCheck hprev.prettyprinter;
208215

216+
# circular dependency in tests
217+
prettyprinter-ansi-terminal = dontCheck hprev.prettyprinter-ansi-terminal;
218+
209219
random = dontCheck hprev.random;
210220

211-
# Disabling doctests.
212-
regex-tdfa = overrideCabal { testTarget = "regex-tdfa-unittest"; } hprev.regex-tdfa;
221+
# Some tests don't work.
222+
regex-tdfa = dontCheck hprev.regex-tdfa;
213223

214224
# the rio test suite calls functions from unliftio that are broken:
215225
# https://github.com/fpco/unliftio/issues/87
@@ -249,6 +259,7 @@ hfinal: hprev: with haskell.lib.compose; {
249259
# requires a version of chell that is not in the stackage resolver
250260
system-filepath = dontCheck hprev.system-filepath;
251261

262+
# circular dep in tests
252263
tasty = dontCheck hprev.tasty;
253264

254265
tasty-discover =
@@ -262,6 +273,9 @@ hfinal: hprev: with haskell.lib.compose; {
262273

263274
tasty-expected-failure = dontCheck hprev.tasty-expected-failure;
264275

276+
# circular dep in tests
277+
temporary = dontCheck hprev.temporary;
278+
265279
test-framework = dontCheck hprev.test-framework;
266280

267281
# requires a version of tasty that is not in the stackage resolver

0 commit comments

Comments
 (0)