From 27b22b2140146a3432c23420849601c0d7bbae53 Mon Sep 17 00:00:00 2001 From: Zoe Wang <33073555+zoewangg@users.noreply.github.com> Date: Fri, 23 Oct 2026 11:44:18 -0700 Subject: [PATCH] test: allow pre-listing no-op warm-up services Listed services no longer have to record nothing, so an entry can be added before the model change that removes a service's last warm-up operation ships. Add lookoutequipment to the list. --- .../allservices/AllServicesWarmUpTest.java | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/test/warmup-tests/src/test/java/software/amazon/awssdk/warmup/allservices/AllServicesWarmUpTest.java b/test/warmup-tests/src/test/java/software/amazon/awssdk/warmup/allservices/AllServicesWarmUpTest.java index 46a629bbadda..ee68d08facb0 100644 --- a/test/warmup-tests/src/test/java/software/amazon/awssdk/warmup/allservices/AllServicesWarmUpTest.java +++ b/test/warmup-tests/src/test/java/software/amazon/awssdk/warmup/allservices/AllServicesWarmUpTest.java @@ -50,7 +50,9 @@ class AllServicesWarmUpTest { /** * Services with no selectable warm-up operation (all operations are streaming or deprecated); warm-up only - * builds and closes the client. + * builds and closes the client. The list is maintained deliberately so that a service losing its warm-up + * operation is surfaced and tracked. An entry may be added before the model change that makes the service no-op + * ships, so listed services are not required to be no-op. */ private static final Set KNOWN_NO_OP_SERVICES = new HashSet<>(Arrays.asList( // All APIs are deprecated @@ -58,6 +60,7 @@ class AllServicesWarmUpTest { "finspacedata", "iotthingsgraph", "lexmodelbuilding", + "lookoutequipment", "proton", // All streaming operations @@ -130,15 +133,11 @@ private void verifyWarmUp(SdkWarmUpProvider provider, String clientClassName) { private void assertExpectedOperationRecorded(SdkWarmUpProvider provider, String clientClassName) { if (KNOWN_NO_OP_SERVICES.contains(serviceName(provider))) { - assertThat(OperationRecordingInterceptor.operationNames()) - .as("%s is listed in KNOWN_NO_OP_SERVICES but recorded an operation; remove the stale entry", - provider.getClass().getSimpleName()) - .isEmpty(); - } else { - assertThat(OperationRecordingInterceptor.operationNames()) - .as("Warm-up of %s must invoke its selected warm-up operation", clientClassName) - .isNotEmpty(); + return; } + assertThat(OperationRecordingInterceptor.operationNames()) + .as("Warm-up of %s must invoke its selected warm-up operation", clientClassName) + .isNotEmpty(); } /**