Repository navigation
PostgreSQL: Display the index operator class before the sort options - #2663
Open
LucaCappelletti94 wants to merge 1 commit into
Open
LucaCappelletti94 wants to merge 1 commit into
LucaCappelletti94 wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2663 +/- ##
=======================================
Coverage 81.25% 81.25%
=======================================
Files 42 42
Lines 33910 33913 +3
Branches 33910 33913 +3
=======================================
+ Hits 27553 27556 +3
Misses 2792 2792
Partials 3565 3565 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CREATE INDEX ii ON t(c ops DESC)was displayed asCREATE INDEX ii ON t(c DESC ops), putting the operator class after the sort options, which no longer parses as the same index column. PostgreSQL'sCREATE INDEXsynopsis puts the operator class first, followed byASC/DESCandNULLS(https://www.postgresql.org/docs/current/sql-createindex.html).The sort modifiers of
OrderByExpr(ASC/DESC,NULLS,WITH FILL) are now written by a shared helper, andIndexColumnprints the column expression, then the operator class, then those modifiers. The parser reads operator classes in every dialect, so the test round-tripsCREATE INDEXcolumns with and without an operator class and sort options in all of them, and checks the parsed operator class and sort order.