Skip to content

Accept VALUE as a synonym of VALUES only in MySQL - #2662

Open
LucaCappelletti94 wants to merge 1 commit into
mainfrom
upstream/sqlite-insert-value
Open

LucaCappelletti94 wants to merge 1 commit into
mainfrom
upstream/sqlite-insert-value

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Contributor

Every dialect accepted VALUE in place of VALUES, as in INSERT INTO t (a) VALUE (1). MySQL documents it ("VALUE is a synonym for VALUES in this context", https://dev.mysql.com/doc/refman/8.4/en/insert.html), but SQLite 3.51.1 and DuckDB 1.4.4 reject it with a syntax error, and the INSERT references of PostgreSQL, SQL Server, Snowflake, BigQuery, Redshift, Spark, ClickHouse and Oracle only list VALUES.

A new dialect method, supports_singular_value_keyword, defaults to false and is enabled for MySQL and the generic dialect. Every other dialect now rejects VALUE with Expected: SELECT, VALUES, or a subquery in the query body, found: VALUE. The existing parse_insert_values test runs its VALUE case on the dialects that keep it, and a new test checks both sides of the capability.

@LucaCappelletti94 LucaCappelletti94 added bug Something isn't working MySQL SQLite labels Oct 17, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.25%. Comparing base (1aabd12) to head (f937872).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2662   +/-   ##
=======================================
  Coverage   81.25%   81.25%           
=======================================
  Files          42       42           
  Lines       33910    33920   +10     
  Branches    33910    33920   +10     
=======================================
+ Hits        27553    27563   +10     
  Misses       2792     2792           
  Partials     3565     3565           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucaCappelletti94
LucaCappelletti94 force-pushed the upstream/sqlite-insert-value branch from f937872 to 9674a9b Compare October 18, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working MySQL SQLite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants