From f2bfcd828486ae80597fc408e0afad3344cdcc2e Mon Sep 17 00:00:00 2001 From: Dianjin Wang Date: Sat, 10 Oct 2026 15:47:44 +0800 Subject: [PATCH] Fix gpdiff.pl duplicate "verbose" option specification With Perl 5.40 (Getopt::Long 2.57, as in Ubuntu 26.04), every run of gpdiff.pl prints a warning: Duplicate specification "verbose|Verbose" for option "verbose" It is printed more than a thousand times in a test run, and it reaches the test output. Getopt::Long ignores case by default and gpdiff.pl does not turn that off (it only sets pass_through), so "Verbose" is already matched by "verbose". Use "verbose" alone. Both -verbose and -Verbose still work. Checked on Ubuntu 26.04: the warning is gone with the new specification, and Ubuntu 24.04 (Getopt::Long 2.54) is not affected either way. Assisted-by: Claude Code Backpatch-through: REL_2_STABLE --- src/test/regress/gpdiff.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/regress/gpdiff.pl b/src/test/regress/gpdiff.pl index c3a4c200ca9..3a9d562f36f 100755 --- a/src/test/regress/gpdiff.pl +++ b/src/test/regress/gpdiff.pl @@ -252,7 +252,7 @@ sub filefunc "man" => sub { lazy_pod2usage(-msg => $pmsg, -exitstatus => 0, -verbose => 2) }, "help" => sub { lazy_pod2usage(-msg => $pmsg, -exitstatus => 1) }, "version|v" => \&print_version , - "verbose|Verbose" => \$glob_atmsort_args{VERBOSE}, + "verbose" => \$glob_atmsort_args{VERBOSE}, "gpd_ignore_plans|gp_ignore_plans" => \$glob_atmsort_args{IGNORE_PLANS}, "gpd_init|gp_init_file=s" => \@{$glob_atmsort_args{INIT_FILES}} );