diff --git a/docs/framework/octane/guide/cell-spanning.md b/docs/framework/octane/guide/cell-spanning.md index eeb2709536..431d718e94 100644 --- a/docs/framework/octane/guide/cell-spanning.md +++ b/docs/framework/octane/guide/cell-spanning.md @@ -68,12 +68,12 @@ A covered cell reports a span of `0`, and the renderer skips it. This is the sam const colSpan = cell.getColSpan() // A span of 0 means the cell is covered by a cell above or to its left. - // Skip it. Do not render `rowSpan={0}`: in HTML that means "span to the + // Skip it. Do not render `rowspan={0}`: in HTML that means "span to the // end of the row group", which merges the cell down the entire tbody. if (rowSpan === 0 || colSpan === 0) return null return ( - + ) diff --git a/docs/framework/octane/guide/column-resizing.md b/docs/framework/octane/guide/column-resizing.md index 62908238eb..d8a38487d8 100644 --- a/docs/framework/octane/guide/column-resizing.md +++ b/docs/framework/octane/guide/column-resizing.md @@ -119,7 +119,7 @@ How you apply these size styles to your markup is up to you, but it is pretty co ```tsx ``` diff --git a/docs/framework/octane/guide/expanding.md b/docs/framework/octane/guide/expanding.md index d280f45ddd..59ddd32624 100644 --- a/docs/framework/octane/guide/expanding.md +++ b/docs/framework/octane/guide/expanding.md @@ -146,7 +146,7 @@ const table = useTable({ {row.getIsExpanded() && ( {/* span however many columns the expanded data needs if it does not share the parent row's columns */} - + {/* Your custom UI goes here */} diff --git a/examples/octane/aggregation/src/main.tsrx b/examples/octane/aggregation/src/main.tsrx index 293ba08e7f..1982915692 100644 --- a/examples/octane/aggregation/src/main.tsrx +++ b/examples/octane/aggregation/src/main.tsrx @@ -218,7 +218,7 @@ function App() @{ {table.getFooterGroups().map((group) => ( {group.headers.map((header) => ( - + {header.isPlaceholder ? null : ( )} diff --git a/examples/octane/basic-dynamic-columns/src/main.tsrx b/examples/octane/basic-dynamic-columns/src/main.tsrx index c01f4840fd..0b10aad9b0 100644 --- a/examples/octane/basic-dynamic-columns/src/main.tsrx +++ b/examples/octane/basic-dynamic-columns/src/main.tsrx @@ -191,7 +191,7 @@ function App() @{ @for (const headerGroup of table.getHeaderGroups(); key headerGroup.id) { @for (const header of headerGroup.headers; key header.id) { - + {header.isPlaceholder ? null : <>
@for (const header of headerGroup.headers; key header.id) { - + {header.isPlaceholder ? null :
', exact: true }) - .evaluate((button) => { + .evaluate(async (button) => { const started = performance.now() ;(button as HTMLButtonElement).click() + // Octane commits a click's updates in the next microtask. + await Promise.resolve() return { elapsed: performance.now() - started, status: document.querySelector('.controls strong')?.textContent, @@ -48,9 +50,10 @@ test('updates pagination atom and row model without errors', async ({ const sortTiming = await page .locator('.sortable-header') .first() - .evaluate((header) => { + .evaluate(async (header) => { const started = performance.now() ;(header as HTMLElement).click() + await Promise.resolve() return { elapsed: performance.now() - started, text: header.textContent, diff --git a/examples/octane/basic-external-state/src/main.tsrx b/examples/octane/basic-external-state/src/main.tsrx index 1a71fc3ffa..5ba290ca20 100644 --- a/examples/octane/basic-external-state/src/main.tsrx +++ b/examples/octane/basic-external-state/src/main.tsrx @@ -93,7 +93,7 @@ function App() @{ @for (const headerGroup of table.getHeaderGroups(); key headerGroup.id) { @for (const header of headerGroup.headers; key header.id) { - + {header.isPlaceholder ? null :
{ + const timing = await next.evaluate(async (button) => { const started = performance.now() ;(button as HTMLButtonElement).click() + // Octane commits a click's updates in the next microtask. + await Promise.resolve() return { elapsed: performance.now() - started, status: document.querySelector('.controls strong')?.textContent, @@ -56,9 +58,10 @@ test('advances controlled pagination repeatedly without render-phase errors', as const sortTiming = await page .locator('.sortable-header') .first() - .evaluate((header) => { + .evaluate(async (header) => { const started = performance.now() ;(header as HTMLElement).click() + await Promise.resolve() return { elapsed: performance.now() - started, text: header.textContent, diff --git a/examples/octane/basic-subscribe/src/main.tsrx b/examples/octane/basic-subscribe/src/main.tsrx index 21f97dbb86..f919160e64 100644 --- a/examples/octane/basic-subscribe/src/main.tsrx +++ b/examples/octane/basic-subscribe/src/main.tsrx @@ -139,7 +139,7 @@ function App() @{ @for (const headerGroup of table.getHeaderGroups(); key headerGroup.id) { @for (const header of headerGroup.headers; key header.id) { - + {header.isPlaceholder ? null : <> {header.column.getCanFilter() @@ -175,7 +175,7 @@ function App() @{ />} - + Page Rows ({String(table.getRowModel().rows.length)}) diff --git a/examples/octane/cell-spanning/src/main.tsrx b/examples/octane/cell-spanning/src/main.tsrx index 78de73474f..d6844b75aa 100644 --- a/examples/octane/cell-spanning/src/main.tsrx +++ b/examples/octane/cell-spanning/src/main.tsrx @@ -175,7 +175,7 @@ function App() @{ {table.getHeaderGroups().map((headerGroup) => ( {headerGroup.headers.map((header) => ( - +