From 069b6a64e134833fce2c366e1c0ee1b5fe09bf51 Mon Sep 17 00:00:00 2001 From: Wonsuk Choi Date: Fri, 23 Oct 2026 12:08:19 +0900 Subject: [PATCH] test(lit-query/createQueryController): read 'queryKey' and 'signal' from the 'queryFn' context to avoid shadowing the 'queryKey' helper --- .../__tests__/createQueryController.test.ts | 32 +++++++++++-------- 1 file changed, 18 insertions(+), 14 deletions(-) diff --git a/packages/lit-query/src/__tests__/createQueryController.test.ts b/packages/lit-query/src/__tests__/createQueryController.test.ts index b32d67980f6..718accbd7e9 100644 --- a/packages/lit-query/src/__tests__/createQueryController.test.ts +++ b/packages/lit-query/src/__tests__/createQueryController.test.ts @@ -539,8 +539,8 @@ describe('createQueryController', () => { this, () => ({ queryKey: [...key, keyId], - queryFn: ({ queryKey }) => { - const id = queryKey[1] as number + queryFn: (context) => { + const id = context.queryKey[1] as number seenKeys.push(id) return sleep(10).then(() => `user-${id}`) }, @@ -796,8 +796,8 @@ describe('createQueryController', () => { this, () => ({ queryKey: [...key, keyId], - queryFn: async ({ queryKey }) => { - const id = queryKey[1] as number + queryFn: async (context) => { + const id = context.queryKey[1] as number if (id === 1) { return sleep(10).then(() => 'value-1') } @@ -902,8 +902,8 @@ describe('createQueryController', () => { this, () => ({ queryKey: [...key, keyId], - queryFn: async ({ queryKey }) => { - const id = queryKey[1] as string + queryFn: async (context) => { + const id = context.queryKey[1] as string return new Promise((resolve) => { if (id === 'old') { resolveOld = resolve @@ -958,15 +958,19 @@ describe('createQueryController', () => { this, () => ({ queryKey: [...key, keyId], - queryFn: async ({ signal, queryKey }) => { - const id = queryKey[1] as 'old' | 'new' + queryFn: async (context) => { + const id = context.queryKey[1] as 'old' | 'new' if (id === 'old') { - oldSignal = signal + oldSignal = context.signal return new Promise((resolve) => { resolveOld = resolve - signal.addEventListener('abort', () => resolve('old-aborted'), { - once: true, - }) + context.signal.addEventListener( + 'abort', + () => resolve('old-aborted'), + { + once: true, + }, + ) }) } @@ -1007,8 +1011,8 @@ describe('createQueryController', () => { this, () => ({ queryKey: [...key, keyId], - queryFn: ({ queryKey }) => { - const id = queryKey[1] as number + queryFn: (context) => { + const id = context.queryKey[1] as number return sleep(Math.max(1, 20 - id)).then(() => `result-${id}`) }, }),