Skip to content
Build

Make DrawingTextCache thread-safe #970

Sign in to view logs

Make DrawingTextCache thread-safe

Make DrawingTextCache thread-safe #970

Triggered via pull request September 14, 2026 11:18
@JimBobSquarePantsJimBobSquarePants
synchronize #420
js/drawing-cache
Status Success
Total duration 3m 59s
Artifacts –

build-and-test.yml

on: pull_request
WarmLFS
19s
WarmLFS
Matrix: Build
Publish
0s
Publish
Fit to window
Zoom out
Zoom in

Annotations

90 warnings
Build (ubuntu-latest, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L148
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (ubuntu-latest, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L73
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (ubuntu-latest, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L66
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (ubuntu-latest, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L373
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (ubuntu-latest, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L373
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (ubuntu-latest, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L354
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (ubuntu-latest, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L341
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (ubuntu-latest, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L331
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (ubuntu-latest, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L144
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (ubuntu-latest, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L144
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (ubuntu-22.04-arm, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L144
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (ubuntu-22.04-arm, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/TestEnvironment.cs#L76
Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)
Build (ubuntu-22.04-arm, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/TestEnvironment.cs#L69
Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)
Build (ubuntu-22.04-arm, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/PolygonFactory.cs#L70
Dereference of a possibly null reference.
Build (ubuntu-22.04-arm, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/PolygonFactory.cs#L69
Converting null literal or possible null value to non-nullable type.
Build (ubuntu-22.04-arm, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/TestEnvironment.cs#L65
Converting null literal or possible null value to non-nullable type.
Build (ubuntu-22.04-arm, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/TestEnvironment.cs#L61
Dereference of a possibly null reference.
Build (ubuntu-22.04-arm, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/TestEnvironment.cs#L59
Converting null literal or possible null value to non-nullable type.
Build (ubuntu-22.04-arm, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.ManualBenchmarks/DrawingThroughputBenchmark.cs#L31
Nullability of reference types in value of type 'List<(IPath Path, SolidBrush? Fill, SolidPen? Stroke)>' doesn't match target type 'List<(IPath Path, SolidBrush Fill, SolidPen Stroke)>'.
Build (ubuntu-22.04-arm, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.Tests/TestFile.cs#L25
Non-nullable field 'bytes' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.
Build (ubuntu-latest, net8.0, 8.0.x, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L148
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (ubuntu-latest, net8.0, 8.0.x, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L73
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (ubuntu-latest, net8.0, 8.0.x, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L66
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (ubuntu-latest, net8.0, 8.0.x, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L373
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (ubuntu-latest, net8.0, 8.0.x, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L373
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (ubuntu-latest, net8.0, 8.0.x, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L354
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (ubuntu-latest, net8.0, 8.0.x, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L341
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (ubuntu-latest, net8.0, 8.0.x, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L331
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (ubuntu-latest, net8.0, 8.0.x, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L144
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (ubuntu-latest, net8.0, 8.0.x, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L144
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (ubuntu-22.04-arm, net8.0, 8.0.x, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L148
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (ubuntu-22.04-arm, net8.0, 8.0.x, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L73
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (ubuntu-22.04-arm, net8.0, 8.0.x, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L66
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (ubuntu-22.04-arm, net8.0, 8.0.x, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L373
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (ubuntu-22.04-arm, net8.0, 8.0.x, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L373
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (ubuntu-22.04-arm, net8.0, 8.0.x, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L354
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (ubuntu-22.04-arm, net8.0, 8.0.x, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L341
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (ubuntu-22.04-arm, net8.0, 8.0.x, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L331
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (ubuntu-22.04-arm, net8.0, 8.0.x, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L144
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (ubuntu-22.04-arm, net8.0, 8.0.x, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L144
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (windows-latest, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.Tests/TestFileSystem.cs#L41
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (windows-latest, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/TestEnvironment.cs#L76
Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)
Build (windows-latest, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/TestEnvironment.cs#L69
Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)
Build (windows-latest, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.Tests/TestFile.cs#L25
Non-nullable field 'bytes' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.
Build (windows-latest, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/PolygonFactory.cs#L70
Dereference of a possibly null reference.
Build (windows-latest, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/PolygonFactory.cs#L69
Converting null literal or possible null value to non-nullable type.
Build (windows-latest, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/TestEnvironment.cs#L65
Converting null literal or possible null value to non-nullable type.
Build (windows-latest, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/TestEnvironment.cs#L61
Dereference of a possibly null reference.
Build (windows-latest, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/TestEnvironment.cs#L59
Converting null literal or possible null value to non-nullable type.
Build (windows-latest, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.ManualBenchmarks/DrawingThroughputBenchmark.cs#L31
Nullability of reference types in value of type 'List<(IPath Path, SolidBrush? Fill, SolidPen? Stroke)>' doesn't match target type 'List<(IPath Path, SolidBrush Fill, SolidPen Stroke)>'.
Build (windows-latest, net8.0, 8.0.x, -x64, false): tests/ImageSharp.Drawing.Tests/TestFileSystem.cs#L41
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (windows-latest, net8.0, 8.0.x, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/TestEnvironment.cs#L76
Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)
Build (windows-latest, net8.0, 8.0.x, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/TestEnvironment.cs#L69
Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)
Build (windows-latest, net8.0, 8.0.x, -x64, false): tests/ImageSharp.Drawing.Tests/TestFile.cs#L25
Non-nullable field 'bytes' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.
Build (windows-latest, net8.0, 8.0.x, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/PolygonFactory.cs#L70
Dereference of a possibly null reference.
Build (windows-latest, net8.0, 8.0.x, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/PolygonFactory.cs#L69
Converting null literal or possible null value to non-nullable type.
Build (windows-latest, net8.0, 8.0.x, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/TestEnvironment.cs#L65
Converting null literal or possible null value to non-nullable type.
Build (windows-latest, net8.0, 8.0.x, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/TestEnvironment.cs#L61
Dereference of a possibly null reference.
Build (windows-latest, net8.0, 8.0.x, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/TestEnvironment.cs#L59
Converting null literal or possible null value to non-nullable type.
Build (windows-latest, net8.0, 8.0.x, -x64, false): tests/ImageSharp.Drawing.ManualBenchmarks/DrawingThroughputBenchmark.cs#L31
Nullability of reference types in value of type 'List<(IPath Path, SolidBrush? Fill, SolidPen? Stroke)>' doesn't match target type 'List<(IPath Path, SolidBrush Fill, SolidPen Stroke)>'.
Build (macos-26, net8.0, 8.0.x, -x64, true): tests/ImageSharp.Drawing.Tests/Processing/DrawingCanvasBatcherTests.cs#L293
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (macos-26, net8.0, 8.0.x, -x64, true): tests/ImageSharp.Drawing.Tests/Processing/Backends/WebGPUExternalSurfaceTests.cs#L47
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (macos-26, net8.0, 8.0.x, -x64, true): tests/ImageSharp.Drawing.Tests/Processing/Backends/WebGPUExternalSurfaceTests.cs#L44
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (macos-26, net8.0, 8.0.x, -x64, true): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L373
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (macos-26, net8.0, 8.0.x, -x64, true): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L373
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (macos-26, net8.0, 8.0.x, -x64, true): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L354
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (macos-26, net8.0, 8.0.x, -x64, true): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L341
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (macos-26, net8.0, 8.0.x, -x64, true): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L331
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (macos-26, net8.0, 8.0.x, -x64, true): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L144
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (macos-26, net8.0, 8.0.x, -x64, true): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L144
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (macos-26, net8.0, 8.0.x, -x64, true): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L144
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (macos-26, net8.0, 8.0.x, -x64, true): tests/ImageSharp.Drawing.Tests/TestUtilities/TestEnvironment.cs#L76
Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)
Build (macos-26, net8.0, 8.0.x, -x64, true): tests/ImageSharp.Drawing.Tests/TestUtilities/TestEnvironment.cs#L69
Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)
Build (macos-26, net8.0, 8.0.x, -x64, true): tests/ImageSharp.Drawing.Tests/TestUtilities/PolygonFactory.cs#L70
Dereference of a possibly null reference.
Build (macos-26, net8.0, 8.0.x, -x64, true): tests/ImageSharp.Drawing.Tests/TestUtilities/PolygonFactory.cs#L69
Converting null literal or possible null value to non-nullable type.
Build (macos-26, net8.0, 8.0.x, -x64, true): tests/ImageSharp.Drawing.Tests/TestUtilities/TestEnvironment.cs#L65
Converting null literal or possible null value to non-nullable type.
Build (macos-26, net8.0, 8.0.x, -x64, true): tests/ImageSharp.Drawing.Tests/TestUtilities/TestEnvironment.cs#L61
Dereference of a possibly null reference.
Build (macos-26, net8.0, 8.0.x, -x64, true): tests/ImageSharp.Drawing.Tests/TestUtilities/TestEnvironment.cs#L59
Converting null literal or possible null value to non-nullable type.
Build (macos-26, net8.0, 8.0.x, -x64, true): tests/ImageSharp.Drawing.Tests/TestFile.cs#L25
Non-nullable field 'bytes' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.
Build (macos-26, net8.0, 8.0.x, -x64, true): tests/ImageSharp.Drawing.ManualBenchmarks/DrawingThroughputBenchmark.cs#L31
Nullability of reference types in value of type 'List<(IPath Path, SolidBrush? Fill, SolidPen? Stroke)>' doesn't match target type 'List<(IPath Path, SolidBrush Fill, SolidPen Stroke)>'.
Build (macos-26, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/SvgBenchmarkHelper.cs#L144
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build (macos-26, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/TestEnvironment.cs#L76
Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)
Build (macos-26, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/TestEnvironment.cs#L69
Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)
Build (macos-26, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/PolygonFactory.cs#L70
Dereference of a possibly null reference.
Build (macos-26, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/PolygonFactory.cs#L69
Converting null literal or possible null value to non-nullable type.
Build (macos-26, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/TestEnvironment.cs#L65
Converting null literal or possible null value to non-nullable type.
Build (macos-26, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/TestEnvironment.cs#L61
Dereference of a possibly null reference.
Build (macos-26, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.Tests/TestUtilities/TestEnvironment.cs#L59
Converting null literal or possible null value to non-nullable type.
Build (macos-26, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.Tests/TestFile.cs#L25
Non-nullable field 'bytes' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.
Build (macos-26, net10.0, 10.0.x, true, -x64, false): tests/ImageSharp.Drawing.ManualBenchmarks/DrawingThroughputBenchmark.cs#L31
Nullability of reference types in value of type 'List<(IPath Path, SolidBrush? Fill, SolidPen? Stroke)>' doesn't match target type 'List<(IPath Path, SolidBrush Fill, SolidPen Stroke)>'.