Skip to content

Commit be4277c

Browse files
committed
fix(mac): scroll the account detail pane so tall content doesn't clip
The detail pane is pinned to a fixed-height container, so an iCloud account — whose sync controls make the form taller — clipped the Hide Read Articles button at the bottom with no way to reach it. Wrap the form in a ScrollView; .scrollBounceBehavior(.basedOnSize) avoids rubber-banding when the content already fits (every non-iCloud account).
1 parent e7dc893 commit be4277c

1 file changed

Lines changed: 11 additions & 1 deletion

File tree

‎Mac/Preferences/Accounts/AccountsDetailView.swift‎

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,16 @@ struct AccountsDetailView: View {
3737
}
3838

3939
var body: some View {
40+
// Scrolls so nothing clips when the pane is shorter than its content
41+
// (e.g. an iCloud account with the sync controls). `.basedOnSize` keeps
42+
// it from rubber-banding when the content already fits.
43+
ScrollView {
44+
accountForm
45+
}
46+
.scrollBounceBehavior(.basedOnSize)
47+
}
48+
49+
private var accountForm: some View {
4050
Grid(alignment: .leading, verticalSpacing: 0) {
4151
GridRow(alignment: .firstTextBaseline) {
4252
Text("Type:")
@@ -120,7 +130,7 @@ struct AccountsDetailView: View {
120130
}
121131
}
122132
.padding(20)
123-
.frame(maxWidth: .infinity, maxHeight: .infinity, alignment: .topLeading)
133+
.frame(maxWidth: .infinity, alignment: .topLeading)
124134
}
125135

126136
private func commitName() {

0 commit comments

Comments
 (0)