From e3407ddadbfcaabc4073c443db326b3d03ffd7bb Mon Sep 17 00:00:00 2001 From: David Trimmer Date: Thu, 10 Sep 2026 14:30:34 -0400 Subject: [PATCH] Address remaining review findings from #9345 Adds anchored 7 CFR 273.7(b)(1)(ii) and 273.24(c)(2)(i) citations to is_snap_ineligible_student, removes a stray USD unit and corrects value_type to bool on the SSI working student exclusion eligibility variable, and adds a month-input aggregation test for is_usda_disabled. Co-Authored-By: Claude Fable 5 Claude-Session: https://claude.ai/code/session_01LqCGPgxDukji8Bhs57c5rH --- changelog.d/9345-review-followup.fixed.md | 1 + .../tests/policy/baseline/gov/usda/is_usda_disabled.yaml | 9 +++++++++ ...ind_or_disabled_working_student_exclusion_eligible.py | 3 +-- .../eligibility/student/is_snap_ineligible_student.py | 6 +++++- 4 files changed, 16 insertions(+), 3 deletions(-) create mode 100644 changelog.d/9345-review-followup.fixed.md diff --git a/changelog.d/9345-review-followup.fixed.md b/changelog.d/9345-review-followup.fixed.md new file mode 100644 index 00000000000..542017df131 --- /dev/null +++ b/changelog.d/9345-review-followup.fixed.md @@ -0,0 +1 @@ +Add anchored SNAP student regulatory citations, correct the SSI working student exclusion eligibility variable type, and add a monthly SSI aggregation test for USDA disability. diff --git a/policyengine_us/tests/policy/baseline/gov/usda/is_usda_disabled.yaml b/policyengine_us/tests/policy/baseline/gov/usda/is_usda_disabled.yaml index 1cdab9f8b50..bcb36c375fa 100644 --- a/policyengine_us/tests/policy/baseline/gov/usda/is_usda_disabled.yaml +++ b/policyengine_us/tests/policy/baseline/gov/usda/is_usda_disabled.yaml @@ -67,3 +67,12 @@ social_security_disability: 100 output: is_usda_disabled: true + +- name: Case 9, monthly SSI receipt in a single month aggregates to a year-level USDA disabled status. + period: 2021 + input: + age: 30 + receives_ssi: + 2021-01: true + output: + is_usda_disabled: true diff --git a/policyengine_us/variables/gov/ssa/ssi/eligibility/income/is_ssi_blind_or_disabled_working_student_exclusion_eligible.py b/policyengine_us/variables/gov/ssa/ssi/eligibility/income/is_ssi_blind_or_disabled_working_student_exclusion_eligible.py index 41e0d875d32..23e6ac8dc24 100644 --- a/policyengine_us/variables/gov/ssa/ssi/eligibility/income/is_ssi_blind_or_disabled_working_student_exclusion_eligible.py +++ b/policyengine_us/variables/gov/ssa/ssi/eligibility/income/is_ssi_blind_or_disabled_working_student_exclusion_eligible.py @@ -2,10 +2,9 @@ class is_ssi_blind_or_disabled_working_student_exclusion_eligible(Variable): - value_type = float + value_type = bool entity = Person label = "Eligible for SSI blind or disabled working student earned income exclusion" - unit = USD definition_period = YEAR reference = ( "https://www.law.cornell.edu/cfr/text/20/416.1112#c_3", diff --git a/policyengine_us/variables/gov/usda/snap/eligibility/student/is_snap_ineligible_student.py b/policyengine_us/variables/gov/usda/snap/eligibility/student/is_snap_ineligible_student.py index c15df2d0a5b..ccf50fffd55 100644 --- a/policyengine_us/variables/gov/usda/snap/eligibility/student/is_snap_ineligible_student.py +++ b/policyengine_us/variables/gov/usda/snap/eligibility/student/is_snap_ineligible_student.py @@ -7,7 +7,11 @@ class is_snap_ineligible_student(Variable): label = "Is an ineligible student for SNAP" definition_period = YEAR defined_for = "is_snap_higher_ed_student" - reference = "https://www.law.cornell.edu/uscode/text/7/2015#e" + reference = ( + "https://www.law.cornell.edu/uscode/text/7/2015#e", + "https://www.law.cornell.edu/cfr/text/7/273.7#b_1_ii", + "https://www.law.cornell.edu/cfr/text/7/273.24#c_2_i", + ) def formula(person, period, parameters): # Base rule: Students enrolled at least half-time in higher education