Skip to content

fix: expand legacy safe-area ignoring layout - #1197

Merged
Kyle-Ye merged 1 commit into
fix/game2048-transitionsfrom
fix/game2048-safe-area-expansion
Oct 19, 2026
Merged

Kyle-Ye merged 1 commit into
fix/game2048-transitionsfrom
fix/game2048-safe-area-expansion

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Expand the child proposal on ignored safe-area edges when using edgesIgnoringSafeArea(_:).
  • Add regression coverage for all edges, the bottom edge, horizontal edges, and an empty edge set, including placement origins.

Stack

Depends on #1196

Related to OpenSwiftUIProject/OpenSwiftUI-2048#1.

@Kyle-Ye
Kyle-Ye added this pull request to stack #1198 October 19, 2026 16:49
@github-actions github-actions Bot added area: layout Layout, geometry, safe area, alignment, stacks, or sizing. type: bug Something is not working correctly. labels Oct 19, 2026
@codecov

codecov Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 29.95%. Comparing base (e223e7b) to head (fe20c1a).

Additional details and impacted files
@@                     Coverage Diff                      @@
##           fix/game2048-transitions    OpenSwiftUIProject/OpenSwiftUI#1197      +/-   ##
============================================================
+ Coverage                     29.93%   29.95%   +0.01%     
============================================================
  Files                           950      950              
  Lines                         76140    76140              
============================================================
+ Hits                          22792    22807      +15     
+ Misses                        53348    53333      -15     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye
Kyle-Ye merged commit da91cd9 into main Oct 19, 2026
6 of 7 checks passed
@Kyle-Ye
Kyle-Ye deleted the fix/game2048-safe-area-expansion branch October 19, 2026 17:11
@tuist

tuist Bot commented Oct 19, 2026

Copy link
Copy Markdown

🛠️ Tuist Run Report 🛠️

Builds 🔨

Scheme Status Duration Commit
OpenSwiftUI ✅ 59.3s 6c953b958

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: layout Layout, geometry, safe area, alignment, stacks, or sizing. type: bug Something is not working correctly.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant