Skip to content

fix: preserve content when applying transitions - #1196

Merged
Kyle-Ye merged 2 commits into
fix/game2048-shape-stylefrom
fix/game2048-transitions
Oct 19, 2026
Merged

Kyle-Ye merged 2 commits into
fix/game2048-shape-stylefrom
fix/game2048-transitions

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Build transition content through the transition body to preserve its layout.
  • Preserve the body's view-list count and cover combined and asymmetric transitions across all phases.

Stack

Depends on #1195

Related to OpenSwiftUIProject/OpenSwiftUI-2048#1.

@github-actions github-actions Bot added area: animation Animation, transitions, transactions, or timing behavior. type: bug Something is not working correctly. labels Oct 19, 2026
@Kyle-Ye
Kyle-Ye added this pull request to stack #1198 October 19, 2026 16:49
@codecov

codecov Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 29.93%. Comparing base (ac881b2) to head (e223e7b).

Additional details and impacted files
@@                     Coverage Diff                      @@
##           fix/game2048-shape-style    OpenSwiftUIProject/OpenSwiftUI#1196      +/-   ##
============================================================
+ Coverage                     29.86%   29.93%   +0.07%     
============================================================
  Files                           950      950              
  Lines                         76136    76140       +4     
============================================================
+ Hits                          22736    22792      +56     
+ Misses                        53400    53348      -52     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye
Kyle-Ye merged commit 8d8d509 into main Oct 19, 2026
6 of 7 checks passed
@Kyle-Ye
Kyle-Ye deleted the fix/game2048-transitions branch October 19, 2026 17:11
@tuist

tuist Bot commented Oct 19, 2026

Copy link
Copy Markdown

🛠️ Tuist Run Report 🛠️

Builds 🔨

Scheme Status Duration Commit
OpenSwiftUI ✅ 2m 33s 02664bcff

Kyle-Ye added a commit that referenced this pull request Oct 19, 2026
* fix: preserve content when applying transitions

* test: tag transition regression tests as aigc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: animation Animation, transitions, transactions, or timing behavior. type: bug Something is not working correctly.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant