Skip to content

fix: restore toggle interaction on iOS - #1189

Merged
Kyle-Ye merged 5 commits into
mainfrom
bugfix/toggle
Oct 18, 2026
Merged

Kyle-Ye merged 5 commits into
mainfrom
bugfix/toggle

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Oct 18, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Restore native hit testing for represented views so the default iOS Toggle responds to taps and updates its binding.
  • Propagate environment and focus changes to platform hosts, apply native enabled state, and update macOS host sizing and view lifecycle behavior.
  • Add iOS and macOS interaction coverage for repeated state changes and disabled toggles.
  • Update DarwinPrivateFrameworks to enable status bar appearance updates through the visionOS UIKit overlay.

Fixes #1187

Dependency

@Kyle-Ye
Kyle-Ye requested a review from Mx-Iris as a code owner October 18, 2026 16:59
@Kyle-Ye Kyle-Ye added this to the 0.24.0 milestone Oct 18, 2026
@github-actions github-actions Bot added area: hosting-bridge SwiftUI bridge, UIHosting/NSHosting, representables, and platform host views. platform: iOS iOS-specific behavior or support. type: bug Something is not working correctly. labels Oct 18, 2026
@Kyle-Ye

Kyle-Ye commented Oct 18, 2026

Copy link
Copy Markdown
Member Author

/interactiontest osui-iag update only-testing=OpenSwiftUIInteractionTests/ToggleInteractionTests

@codecov

codecov Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 25.35%. Comparing base (f41aa23) to head (31508d8).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...tform/PlatformViewRepresentableLayoutOptions.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1189      +/-   ##
==========================================
- Coverage   29.90%   25.35%   -4.55%     
==========================================
  Files         942      883      -59     
  Lines       73918    64814    -9104     
==========================================
- Hits        22102    16436    -5666     
+ Misses      51816    48378    -3438     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tuist

tuist Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

🛠️ Tuist Run Report 🛠️

Tests 🧪

Scheme Status Ran test modules Commit
OpenSwiftUI ✅ 7 b4fe644cf

Builds 🔨

Scheme Status Duration Commit
OpenSwiftUI ✅ 1m 12s b4fe644cf

@Kyle-Ye
Kyle-Ye merged commit 39d2cfe into main Oct 18, 2026
1 of 6 checks passed
@github-actions github-actions Bot added area: event-gesture Events, gestures, tracing, or interaction plumbing. platform: macOS macOS-specific behavior or support. labels Oct 18, 2026
@Kyle-Ye
Kyle-Ye deleted the bugfix/toggle branch October 18, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: event-gesture Events, gestures, tracing, or interaction plumbing. area: hosting-bridge SwiftUI bridge, UIHosting/NSHosting, representables, and platform host views. platform: iOS iOS-specific behavior or support. platform: macOS macOS-specific behavior or support. type: bug Something is not working correctly.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Toggle touch input on iOS

1 participant