You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit dfa77ef
Browse filesBrowse the repository at this point in the historyBrowse files
solarcam: run ffmpeg without a shell; camera-supplied file names reached it (#15)
convertFile() ran ffmpeg with shell=True on paths built from the FileName the camera returns from OPFileQuery, so a hostile camera could run commands on the downloading host whenever target_filetype_video was set. ffmpeg now gets an argv list, and generateTargetFilePath() keeps only [A-Za-z0-9_-] in the derived name; real names (2024-01-15_12-00-00) are unchanged.
A failed conversion no longer deletes the downloaded recording: the source is kept, the partial output removed, and the next cycle retries the conversion without downloading again.
Reported by @waseem-cve (GHSA-w2h5-ww59-7hxr).
0 commit comments