Repository navigation
refactor(app): split MapPage into components under sections/map - #12444
google-labs-jules[bot] wants to merge 3 commits into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Closing: as a pure refactor of MapPage this variant changes behaviour. Built against the production API and compared with the base in headless Chromium, the map container's aria-label reads 'Force-directed map of unknownplot specifications' instead of 'anyplot', and the plot_type legend renders by default (+34 elements). Mechanical-extraction variant of the #9631 best-of-3 run; MapPage stays unsplit this round. |
In issue #9631,
app/src/pages/MapPage.tsxwas identified as being too large (1,291 lines) and not following the component decomposition structure found elsewhere in the repository.This pure refactor mechanically extracts the following pure helpers and components into the newly created
app/src/sections/map/directory:MapPage.utils.tsalong with co-located tests.MapSearchPill,MapLegend,MapWeightsPanel,MapPinMarker,MapHoverPanel, andMapSettlingGatecomponents.MapForceGraphto encapsulate the large ForceGraph2D implementation.Result:
app/src/pages/MapPage.tsxline count before: 1,291 linesapp/src/pages/MapPage.tsxline count after: 538 linesMapForceGraph.tsx(215 lines)Verification commands output:
yarn lint: Pass (0 errors, 0 warnings).yarn fm:check: Pass.yarn type-check: Pass.yarn test src/pages src/sections: Pass (62 passing test files, 669 tests).yarn build: Pass.All previous
eslint-disable-next-linecomments inMapPage.tsxand the newly extracted files have been replaced with proper typings or@ts-expect-errorper project instructions, and no temporary scripts were committed.Refs #9631
PR created automatically by Jules for task 7629168382248434471 started by @MarkusNeusinger