You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Repair pre-commit, drop pixi.lock, point .gitattributes at uv.lock (#67)
.pre-commit-config.yaml had rotted into a trap. It ran ruff-format while
CI enforces black, and the two disagree: black reports the tree clean,
ruff format rewrites five files, and black then rejects one of them. Any
contributor who ran `pre-commit install` would have had their commits
reformatted into a state that fails the lint job. It went unnoticed only
because nothing runs it -- no git hook is installed and no workflow
invokes it -- despite pre-commit sitting in the lint dependency group.
Formatting is now black's alone, running after ruff-check so the
formatter has the last word. Hook revs are current: ruff was pinned at
0.12.1 against a project on 0.16.3, and prettier pointed at
pre-commit/mirrors-prettier, which upstream archived; that moves to the
maintained rbubley fork. A pre-commit ecosystem is added to dependabot so
these stop drifting silently.
Deleting the config instead would have been simpler but would have
dropped codespell, validate-pyproject, and prettier, none of which CI
runs.
With the hooks working, codespell found eleven hits. Five were false
positives -- `lamda` is the LAMDA lab's domain in author emails, `anc` a
local for "ancestors" -- and are now in ignore-words-list with a note.
The other six are corrected, including "Subsequnce" in IKTOD's class
docstring and a misspelled variable in a doctest example, both
user-facing.
prettier also normalized indentation in three workflow files and removed
a blank line from mkdocs.yml, the first time it has run over them.
Verified the parsed YAML is identical before and after, and that the docs
still build under --strict.
pixi.lock is removed: 438K of lockfile with no pixi.toml and no
[tool.pixi] section, orphaned since the move to uv. .gitattributes
existed only to mark it generated, so it now does the same for uv.lock,
which collapses that file in diffs and keeps it out of language stats.
Copy file name to clipboardExpand all lines: docs/contributing/contribution.md
+2-2Lines changed: 2 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -47,7 +47,7 @@ Tips
47
47
- Anything in the `dev` branch should be deployable (no failing tests).
48
48
- Never use `git add .`: it can add unwanted files;
49
49
- Avoid using `git commit -a` unless you know what you're doing;
50
-
- Check every change with `git diff` before adding then to the index (stage area) and with `git diff --cached` before commiting;
50
+
- Check every change with `git diff` before adding then to the index (stage area) and with `git diff --cached` before committing;
51
51
- If you have push access to the main repository, please do not commit directly to `dev`: your access should be used only to accept pull requests; if you want to make a new feature, you should use the same process as other developers so that your code can be reviewed.
52
52
53
53
Documentation Guidelines
@@ -68,7 +68,7 @@ Code Guidelines
68
68
Tests
69
69
-----
70
70
71
-
We use [Github Actions](https://github.com/features/actions)for continous integration
71
+
We use [Github Actions](https://github.com/features/actions)for continuous integration
72
72
and python [pytest](https://docs.pytest.org/en/stable/index.html) for writing tests.
73
73
You should write tests for every feature you add or bug you solve in the code.
74
74
Having automated tests for every line of our code let us make big changes
0 commit comments